Skip to content

BVAL-231 Register RecordELResolver - #283

Open
pzygielo wants to merge 4 commits into
apache:bval-3.1.xfrom
pzygielo:bval-231
Open

pzygielo wants to merge 4 commits into
apache:bval-3.1.xfrom
pzygielo:bval-231

Conversation

@pzygielo

@pzygielo pzygielo commented Nov 2, 2026

Copy link
Copy Markdown

I'd need more time to prepare UTs.

@tandraschko

Copy link
Copy Markdown
Member

can you please also add it to master?

@tandraschko
tandraschko marked this pull request as ready for review November 2, 2026 09:36
@jungm

jungm commented Nov 2, 2026

Copy link
Copy Markdown
Member

think we should build a similiar behavior as hibernate validator did here: hibernate/hibernate-validator#2211

@pzygielo

pzygielo commented Nov 2, 2026

Copy link
Copy Markdown
Author

@jungm

jungm commented Nov 2, 2026

Copy link
Copy Markdown
Member

i just pushed commits for this, think jakartaee/expression-language#489 doesnt apply to us here

we only have an on/off toggle to enable/disable el in message patterns

@jungm

jungm commented Nov 2, 2026

Copy link
Copy Markdown
Member

i can also agree on using RecordELResolver directly imo, just saw that you raised the same issue with hv and that they chose to go down a different route

@pzygielo

pzygielo commented Nov 2, 2026

Copy link
Copy Markdown
Author

https://github.com/apache/bval/pull/283/changes#diff-62396f4f9f90a675ab292a06ebc369992fd04075777594f88b7cd85bd97c115dR352

@NotNull(message = "Record value ${validatedValue.name} (${validatedValue.displayName}) is invalid")
        public Item recordValue;

is almost exactly what I started this whole thing with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants