MINOR: [C++] Bump bundled GTest version - #51242
Merged
Merged
Conversation
This seems to fix some compilation errors with recent clang compilers.
Member
Author
|
Example failing C++ Extra workflow (without these changes): https://github.com/apache/arrow/actions/runs/34227884512 |
pitrou
marked this pull request as ready for review
September 8, 2026 17:48
Member
Author
|
@kou This fixes all the C++ Extra failures. Do you want me to open an issue? |
Member
Author
|
@github-actions crossbow submit -g cpp |
kou
approved these changes
Sep 8, 2026
kou
left a comment
Member
There was a problem hiding this comment.
+1
We don't need to create a new issue but could you add more context/information such as real error messages to the PR description or PR comment before we merge this? It may be useful when we search our history later.
|
Revision: 3779014 Submitted crossbow builds: ursacomputing/crossbow @ actions-41630fb4a0 |
Member
Author
|
Okay, I update the PR description and will merge. Thank you @kou ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This fixes some compilation errors with recent clang compilers, as seen on some of the C++ Extra workflow builds (on macOS, but I got similar errors on Ubuntu 24.04 with recent conda-forge compilers).
Example errors include:
Are these changes tested?
By existing CI jobs. Also tested locally.
Are there any user-facing changes?
No.