Repository navigation
Conversation
The handler returns the position values plus a computed `fov` object, but the OpenAPI response schema was a map of numbers and strings only, so generated clients rejected real responses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused schema correction matches the existing response structure and introduces no runtime changes or unresolved issues.
0 open findings
What changed in this PR
Corrects the OpenAPI response schema for GET /info/position to describe the existing response accurately.
Changes:
- Documents the required
fovobject and its six numeric fields. - Preserves additional number-or-string position values without changing runtime behavior.
| File | Description |
|---|---|
| src/modules/info/get_info_handler.ts | Defines and uses the response schema containing fov. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /info/positionreturns the camera's position values plus the computedfovobject (info.fov = getFOV(...)inget_info_handler.ts), but its OpenAPI response schema wasPositionMapSchema(a map of numbers and strings only). Clients generated from the spec, such as the cams control SDK in alveusgg/alveusgg#2412, rejected every real response becausefovis an object.This documents the response as an object with a required
fov(hFOV,vFOV,focalLength,x,y,multiplier), plus the position values as before (additionalProperties: number | string). Runtime behaviour is unchanged; only the spec is affected.Testing
feat/local-mocks).GETendpoint's real response against the spec:/info/positionwas the only one that didn't match, and it does now.🤖 Generated with Claude Code