Skip to content

feat(windows): add NVM v2 migration with npm adoption - #7

Merged
alsd4git merged 5 commits into
mainfrom
feat/windows-nvm-v2
Nov 8, 2026
Merged

alsd4git merged 5 commits into
mainfrom
feat/windows-nvm-v2

Conversation

@alsd4git

@alsd4git alsd4git commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Why

  • Manage Node versions on Windows while preserving an existing standalone installation's npm globals during migration.

How

  • Install NVM for Windows v2 and ask separately before adopting standalone Node.
  • Save a package inventory and verify the adopted Node and global package versions; report incomplete migrations.
  • Document the community installer's adoption behavior and add planning and inventory tests.

Tests

  • powershell.exe -NoProfile -File tests/windows-node-tests.ps1 and PowerShell 7: passed.
  • Windows Sandbox: installed standalone Node 24.22.1 and is-number@7.0.0, then migrated through the branch bootstrap; inventory verification and removal of standalone Node passed.
  • Node 26 host: six existing global CLI tools reported their expected versions after migration. This is an execution smoke test, not full functional coverage of each tool.
  • The Sandbox test exercised explicit noninteractive consent and one fixture package; the interactive prompt and additional migration scenarios still need review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T21:19:54.818197Z 041f1de PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 041f1deb9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread windows/Dotfiles.WindowsNode.psm1 Resolved
@alsd4git
alsd4git force-pushed the feat/windows-nvm-v2 branch from b1401d5 to afeb66b Compare November 8, 2026 23:38
@alsd4git
alsd4git merged commit 98d88ba into main Nov 8, 2026
13 checks passed
@alsd4git
alsd4git deleted the feat/windows-nvm-v2 branch November 8, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant