Repository navigation
feat(plugin): align legacy marketplace component discovery with Copilot - #604
Merged
Merged
Conversation
Deploying allagents with
|
| Latest commit: |
f5ddd65
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ffdf47e.allagents.pages.dev |
| Branch Preview URL: | https://fix-marketplace-mcp-discover.allagents.pages.dev |
Contributor
Author
|
Dogfooded candidate
Detailed source revisions, private repository names, endpoints, and the original machine-readable receipt are retained in the private research archive. This anonymized summary replaces the earlier detailed comment. No authenticated MCP calls, model sessions, or hook execution were tested. No full-suite rerun was performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #603.
Align legacy marketplace component discovery with observed Copilot behavior without turning
.github/into a whole-directory copy.strictis not a component allowlist.agents/,instructions/,prompts/,skills/,hooks/,scripts/,tools/, andcopilot-instructions.md. Preserve existing GitHub-agent precedence and supporting portable hook resources.hooks:falsedisables both portable and raw GitHub hooks without dropping other assistant resources.The deliberate PR #443 boundary remains: native plugin components and repository assistant overlays are different sources; repository development configuration is not implicitly distributable. Its undeclared-native-component suppression is replaced by evidence-backed discovery, not by arbitrary directory copying.
Investigation and native evidence
Original suppression:
getMarketplaceFileArtifactsin 1.22.0 disabled omitted MCP forstrict:false;collectMcpServersthen skipped conventional MCP discovery.Native Copilot 1.0.103 investigation: 72 isolated fixtures, 227 native CLI commands. Covered strict variants; manifest presence and combinations; custom directories/files and inline configurations; empty selections; invalid declarations; source precedence; and local-live versus cloned installs. The original omitted-root-MCP case was also verified with Codex 0.164.0.
Observed legacy precedence:
.plugin/plugin.json, rootplugin.json,.github/plugin/plugin.json,.claude-plugin/plugin.json.hooks.json, thenhooks/hooks.json..mcp.json,.github/mcp.json, plugin-manifestmcpServers, marketplace-entrymcpServers; alternatives, not additive sources.Copilot marketplace reference, legacy file locations, and AllAgents discovery/migration documentation.
GitHub assistant roots are not synonymous with CI metadata: repository instructions, prompt files, and custom agents. Their supported-root boundary is shared in
GITHUB_ASSISTANT_ENTRIES.Native investigation did not invoke authentication, model sessions, MCP connections or hook processors. AllAgents deliberately fails closed on invalid selected configurations even where native readers fall back. No new LSP synchronization, MCP plugin-root environment/cwd substitution, unsupported hook translations, or portable Agent Plugins
mcp.jsonschema support.Verification on corrected implementation
Bun 1.4.0; heavy work ran in the fixed
agent-verificationsystemd unit underagent-verification.slice.bun test, 203 filesbun run typecheckbun run lintbun run buildReal publisher upgrade proof
Used task-owned copies of seven WTG.AI.Prompts plugins and their actual marketplace entries:
aim,arch-prc,cargowise,org,skill-usage-metrics,vcs-workflow, andai-evals. Separate empty HOME/project/client roots for each scope; no publisher repository edits. The baseline was the publishedallagents@1.22.0bundle.70 actual CLI commands registered the local marketplace, installed with 1.22.0, updated the same installation with the corrected
dist/index.js, then installed fresh with the corrected CLI:All existing supported assistant files and non-JSON portable hook resources retained their paths and SHA-256 bytes. No previously installed assistant resource disappeared or changed. Fresh installs contained no
.github/workflows/,.github/plugin/, or corresponding.copilot/metadata.Ownership limit observed: six user-scope baseline installations had one legacy metadata file that was not removed by the update. It was not newly distributed by the corrected CLI; fresh installs omitted it. Previously untracked/user-owned files are not claimed for deletion.
Earlier publisher comparison exposed agent/instruction/prompt/script/tool losses and portable hook resource removal. The corrected regressions cover strict variants, manifest-addition updates, assistant-root filtering, excluded/unsafe sources, hook opt-out, GitHub-agent precedence and profile materialization. The full suite also exposed the overloaded GitHub/root-skill flag; separating those states restored the existing root-skill inventory contract.
Earlier built CLI evidence additionally covered four-client MCP configuration preservation, custom component replacement, invalid-source rollback, hook opt-out, plugin removal, profile install/remove and TUI skill inventory/update. Remote CI for the new commit, authenticated MCP connectivity and Windows-only runtime behavior are not claimed here.
Local evidence:
/tmp/allagents-native-full-evidence.json,/tmp/allagents-full-built-evidence.json,/tmp/allagents-full-tui-evidence.json,/tmp/allagents-604-ci-smoke-evidence.json,/tmp/allagents-604-review-smoke-evidence.json,/tmp/allagents-publisher-upgrade-evidence.json, and/tmp/allagents-assistant-upgrade-fixed-evidence.json. Temporary smoke scripts, dependency installs and fixtures were removed.Release and shipping
PR title remains
feat(plugin): align legacy marketplace component discovery with Copilot. The earlier release-please 17.11.2 smoke parsed this as non-breakingfeatand calculated 1.22.0 → 1.23.0 using repository configuration. No manual version, tag or CHANGELOG changes. Release Please finalizes the release through its generated PR. Nothing is merged by this task.