Repository navigation
Handle escaped quotes while parsing JSON - #10
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Owner
|
Hi, thanks for the contribution! I think a recent refactor I did in 5fbd07 actually fixed this though, so I'll close for now. Let me know if there are remaining issues. |
Author
|
Thanks for the follow-up. I checked the current master parser: escaped characters are skipped while locating string boundaries, comment stripping preserves escaped characters inside strings, and bracket matching accounts for escapes. I do not see a remaining issue from the reported escaped-quote case, so the closure is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
JSONParsertoggled its in-string state for every quote, including escaped quotes. A valid string containing\"could therefore expose an embedded//as a comment and braces as JSON structure. Quote handling now accounts for preceding backslash parity when stripping comments, finding string boundaries, and matching brackets. Added a synthetic regression case with escaped quotes, a comment marker, and a closing brace inside the value.Validation and scope
git diff --checkpassed.FlexTestsuite but was not run locally: no C++ compiler/build tools (clang++,g++,cl,cmake, orninja) are available. CI was not queried or awaited.