Repository navigation
Fix ambiguity from repeated embedded field types - #80
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
Count repeated embedded types at each depth so their fields stay ambiguous through further promotion. Visit each type once per depth and cap counts at two to avoid expanding duplicate paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
What & why
Closes #79.
Two wrappers embedding Common previously emitted its ambiguous X field using the first wrapper's value.
Track repeated embedded types at each depth so those conflicts are omitted, including through further embedding levels.
Counts stop at two, and each type enters the queue once per depth.
Compatibility: formerly emitted ambiguous fields disappear. Shallow fields, unique tagged winners and explicitly named parent paths retain their output.
The public API and error strings stay the same.
Both packages pass
go test -v -cover ./...andgo test -race ./...on Go 1.17.13 and 1.23.4.Build, vet and formatting pass on both versions. Eleven new cases check all three encoder APIs.
Eighteen assertions fail against unchanged master and pass with this fix.
Checklist
gofmt,go vet, andgo test ./...pass (root and./multipart).