Skip to content

Fix missing-gcloud harness check on hosted runners - #8

Merged
howardjohn merged 1 commit into
agentgateway:mainfrom
danehans:fix-shell-harness-path
Oct 28, 2026
Merged

howardjohn merged 1 commit into
agentgateway:mainfrom
danehans:fix-shell-harness-path

Conversation

@danehans

@danehans danehans commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

The missing-gcloud test assumes /usr/bin:/bin excludes gcloud, but hosted runners install it there. Give the check an isolated PATH and print its captured output when the assertion fails.

Separate CI harness fix for #7.

Use a controlled PATH so installed cloud tools cannot affect the check.
Print the captured output when the missing-tool assertion fails.

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans

Copy link
Copy Markdown
Contributor Author

@howardjohn PTAL

@danehans

Copy link
Copy Markdown
Contributor Author

@howardjohn thanks for the /approve. I don't have permissions to merge PRs, so please merge or update my permissions to unblock #7.

@howardjohn
howardjohn merged commit d53aaaa into agentgateway:main Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants