Repository navigation
Fix missing-gcloud harness check on hosted runners - #8
Merged
Merged
Conversation
Use a controlled PATH so installed cloud tools cannot affect the check. Print the captured output when the missing-tool assertion fails. Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Contributor
Author
|
@howardjohn PTAL |
howardjohn
approved these changes
Oct 28, 2026
Contributor
Author
|
@howardjohn thanks for the /approve. I don't have permissions to merge PRs, so please merge or update my permissions to unblock #7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing-gcloud test assumes
/usr/bin:/binexcludes gcloud, but hosted runners install it there. Give the check an isolated PATH and print its captured output when the assertion fails.Separate CI harness fix for #7.