Repository navigation
chore: delete recorded pins, baselines and version copies - #20
Merged
Merged
Conversation
Derive the generator's semantic-core base from the manifest's declared semantic.semantic_core and read the same declaration in conftest, instead of hand-typed 0.3.0 copies. Delete the baseline-0.2.0 fixture, the additive compatibility tests and NFR-001 with its criteria and test rows, the @typespec/compiler version in the Node error text, and version and origin/main prose in the spec, manifest comments and IT-002. Emitted schemas are byte-identical. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes recorded pins, frozen baselines and hand-typed version copies (owner rulings D1/D2);
semantic.semantic_corestays as the one declared pin.scripts/generate-schemas.mjsderives the semantic-core base fromsemantic.semantic_core;tests/conftest.pyreads the same declaration. Emitted schemas are byte-identical (make schemas-checkpasses with no regeneration diff).tests/fixtures/baseline-0.2.0/,tests/test_additive_compatibility.py, the baseline-reading tests intest_manifest_semantic.py, NFR-001 (andspec/non-functional/), FR-003 baseline sentences/CON-2/AC wording, and TC-033/TC-080..083.@typespec/compiler 1.15.0clause from the Node error text, the0.3.0prose in FR-002/FR-003, the 0.2.0/0.3.0 comments inmanifest.yaml, and the "built from main / (source, ref, sha)" prose in IT-002.Gates: pytest 150 passed / 7 skipped / 2 xfailed (control on main: 156 / 7 / 3; the delta is the deleted baseline tests), ruff, black, schemas-check all pass.
🤖 Generated with Claude Code