Skip to content

Validate preconditions on binding updates (1.0.2) - #20

Merged
agammann merged 1 commit into
mainfrom
qa/latch-precondition-update
Oct 30, 2026
Merged

agammann merged 1 commit into
mainfrom
qa/latch-precondition-update

Conversation

@agammann

Copy link
Copy Markdown
Owner

Summary

  • Validate every declared precondition callback before replacing a scope binding; an invalid update leaves the prior binding live.
  • Add a regression that failed on the old behavior and now checks the PRECONDITION error and preserved handler.
  • Prepare the matching 1.0.2 package set because 1.0.1 is already published. Published 1.0.1 installation links remain accurate until the patch release.

Local verification

  • Red before fix: focused test failed with Missing expected exception.
  • Exact pnpm 10.17.1 frozen install and build passed.
  • Synthetic Node suite: 27/27 passed on Windows.
  • Six tarballs packed; package and production-bundle audit: 8/8 passed.
  • Disposable installed-package smoke: CLI reports 1.0.2 and runtime rejects the missing callback while preserving the original binding.

CI runs the isolated Chromium fixture lanes and package consumer on Windows and Ubuntu. No user data or live provider was used locally.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T03:24:34.271659Z 357f788 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@agammann
agammann merged commit 5cb02b5 into main Oct 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants