Repository navigation
fix(132): remove leftover plural-name rule for list response field - #422
Closed
laurencehook-lr wants to merge 1 commit into
Closed
laurencehook-lr wants to merge 1 commit into
laurencehook-lr wants to merge 1 commit into
Conversation
…rify response message field requirements Line 102 requires the list response array to be named `results`; the bullet at lines 114-116 still said it must be named for the English plural term. Reword it so it no longer conflicts.
4 of 7 tasks
Author
|
Superseded by #423 (same change, clean commit message). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 102 of AEP-132 requires the list response array to be named
results(added in #355), and the OAS tab (line 129) and the generatedListBooksResponseexample agree. The bullet at lines 114–116 still said the field must be "named for the English plural term for the resource", which looks like a leftover from the AIP text and contradicts line 102. #378 made the same alignment for AEP-231.This rewords the bullet so it no longer conflicts, and keeps the "no other repeated fields" constraint.
make checkpasses.🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(run
make lint)💝 Thank you!