Skip to content

Incorrect method for inspecting ambiguous results #91

Description

@ehenneken

This looks like a bug, but an additional set of eyes is needed to confirm that it actually is.

When no candidate solutions are found with a score above a the minimal score, and there actually are candidate solutions, the doubtful solutions are inspected.

    if len(filtered)==0:
        if candidates:
            current_app.logger.debug("No score above minimal score, inspecting doubtful solutions.")
            return inspect_doubtful_solutions(candidates, query_string, hypothesis)
        raise NoSolution("Not even a doubtful solution")

However, the call inspect_doubtful_solutions(candidates, query_string, hypothesis) seems incorrect and probably should have been

inspect_ambiguous_solutions(candidates, query_string, hypothesis)

This method actually returns, while the current call only raises exceptions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions