fix: revert dev-terms acceptance preflight (#262) to unblock non-interactive CI - #266
Merged
AnujVishwakarma-src merged 1 commit intoSep 23, 2026
Conversation
…-interactive CI PR adobe#262 added an interactive Developer Terms preflight to console commands. In a non-interactive context (e.g. `aio console:project:select` in a CI pipeline) the y/n acceptance prompt blocks with no non-interactive path and the job is terminated with exit 130, breaking automation that worked on 5.4.1. adobe#262 was merged 2026-06-12 but first released in 5.4.2 (2026-09-15), so the pre-adobe#262 behavior was the shipped reality on 5.4.1 for the prior ~4 months; this revert restores it. The @adobe/aio-lib-ims ^8 bump from adobe#263 is kept.
aroragarvit666-hue
approved these changes
Sep 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #262 ("feat: fix the 451 CoreConsole error into a better user flow to accept developer terms") added an interactive Developer Terms preflight (
ensureDevTermAccepted) to the console commands. It promptsDo you accept the terms? (y/n)whenever the org's terms are not bothacceptedandcurrent.In a non-interactive context — e.g.
aio console:project:selectrun as a CI/CD step — that prompt has no non-interactive path (the fail-fast branch only triggers on--json/--yml). The prompt blocks, the runner terminates the process, and the job exits with code 130, breaking pipelines that worked on5.4.1.Why revert is safe
#262 was merged 2026-06-12 but first released in
5.4.2(2026-09-15). For the ~4 months before that,5.4.1— with no terms preflight — was the shipped behavior every user ran. This revert simply restores that prior, known-good behavior. Terms-accepted orgs (which previously worked in CI) are unblocked immediately.Scope
ensureDevTermAccepted+DEV_TERMS_URLfromsrc/commands/console/index.js, the preflight call from the 13 command files, thehyperlinkerdependency, and the associated test changes.@adobe/aio-lib-ims ^7 → ^8bump from fix: bump @adobe/aio-lib-ims ^7 -> ^8 to drop deprecated uuid@8 (APPBLD-4864) #263 (unrelated, still wanted).Validation
package.json:hyperlinkerremoved,@adobe/aio-lib-imsstays^8.Note for the Console team
This is your feature — raising as a fast revert to unblock a customer's CI now. If you prefer to keep the interactive 451 improvement, a targeted alternative is to make
ensureDevTermAcceptedskip the prompt when!process.stdin.isTTY/ in CI (fail fast or bypass) rather than a full revert. Happy to switch to that approach. Tracking on the engineering side under the Developer-Terms follow-up.