Repository navigation
generated_poc deprecation points at a codemod that doesn't rewrite; types docstring still forbids adcp.types.domains #1417
Description
Post-merge audit of #1392 found stale migration guidance:
- The
generated_pocDeprecationWarning (src/adcp/types/_generated_poc_alias.py~L14 and ~L259-261) anddocs/types-9-migration.md(~L229) sayadcp migrate v3-to-v4rewrites old imports. It doesn't: run with--auto-apply, it only flags them, with a stale "import from adcp.types instead" message. Either teach the codemod theadcp.types.generated_poc.->adcp.types.domains.prefix rewrite (preferred; it's a mechanical rename and identity is guaranteed), or stop advertising it. - The
src/adcp/types/__init__.pymodule docstring (~L24-27) still says never to import fromadcp.types.domains, while the deprecation warning and docs now point adopters there.
Acceptance: the warning text, the docs and the codemod agree. If the codemod gains the rewrite, test it on a file with several deep generated_poc imports, including the brand → brand_discovery split.
Activity
bokelley commentedon Oct 6, 2026
Triage
Classification: Bug
Bucket(s): docs, client
Status: deferred
What the experts said:
My take: PR #1420 was opened by the same author minutes after this issue and fully addresses both acceptance items: the codemod now rewrites
adcp.types.generated_poc.prefixes toadcp.types.domains.(brand split included), and theadcp.typesmodule docstring is corrected to permit domain path imports. Once #1420 merges, the issue auto-closes.Blocked-on: #1420 — resurfaces on merge
Triaged by Claude Code. Session: https://claude.ai/code/session_014xFQsnvJq11b2hZW96mgjz
Generated by Claude Code
fix(migrate): rewrite generated_poc imports to adcp.types.domains, sp…