Repository navigation
Expose browser-bound OAuth verification outcomes without login - #140
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atom's OAuth callback currently reports an unverified account without a trusted identity that the relying application can use to distinguish registration from login. This causes Atomic login to offer email verification to people who never signed up for Builder (absmach/atomic#279).
For browser-bound flows, include an opaque single-use
verification_codewith the existing verification-required callback.POST /auth/oauth/verificationredeems it for the provider-confirmed entity ID/email without issuing a session, verifying email or linking a provider. The callback URL contains neither email nor entity ID. Existing clients retain the original error outcome.Recovery codes reuse the existing exchange-code store with a separate prefix and a purpose-bound secret hash: changing the prefix cannot turn recovery into login. Browser binding, expiry and atomic single-use checks apply to both purposes. No database migrations or new environment variables.
Validation:
cargo clippy -- -D warnings,cargo fmt --check, API-contract hashes and database/storage boundary checks pass.Deploy this companion change before Atomic's fix for absmach/atomic#279. Live provider logins and production deployment were not run.