Repository navigation
fix: keep a resolved lock when a later presence message lists it as pending - #366
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
ttypic
approved these changes
Oct 6, 2026
ttypic
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for contributing
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #338
Description
When a member acquires several locks concurrently, for example with
Promise.all(),acquire()publishes one presence update per lock. Each update carries every lock request the member has so far, and none of them are resolved yet, so the later messages list the earlier locks aspendingagain.Locks.processPresenceMessageresolves apendingrequest tolocked(orunlocked) when it first sees it. When the next message arrived, the same request was still listed aspending, so the stored lock moved back fromlockedtopending. The update event reportedpending, and no later event reportedlockedagain. Depending on message order, only some of the locks stayedlocked, which matches the inconsistent results in #338.This change ignores a
pendingentry when the stored request for the same lock has the same timestamp and is already resolved.Testing
Lockstest that processes two presence messages in the orderacquire()publishes them:[a pending], then[a pending, b pending]. It expects both locks to belocked.expected 'pending' to be 'locked', 1 failed of 21) and passes with it (21 passed).prettier --checkandeslintare clean.Run with: