Repository navigation
Num beta osc stage length - #175
Open
ben-c-2013 wants to merge 117 commits into
Open
ben-c-2013 wants to merge 117 commits into
ben-c-2013 wants to merge 117 commits into
Conversation
…gives a given number of main beam betatron oscillations.
…c() to calculate the number of betatron oscillations a particle can undergo in the stage.
… betatron oscillations that should be performed in the main flattop by subtracting the contributions from the ramps.
…d Stage.flattop_length2num_beta_osc() for calculating the number of betatron oscillations when the gradient is small (usually the case for ramps).
…ted various docstrings.
…top_length2num_beta_osc().
… ramps are uniform type.
…beta_osc_stage_length
…fying Stage.flattop_length2num_beta_osc() and Stage.calc_flattop_num_beta_osc().
…es/stage/stage.py.
…ength_num_beta_osc() and removed unnecessary comments and imports in some of the beatron oscillation length and phase advance class methods.
… flattop lengths to match the number of betatron oscillations.
…rive beam with an angular offset will follow when driver guiding is applied. Also added getter and setter for StageHipace.external_focusing. The setter will also calculate the gradient for the external focusing field.
…river_guiding_orbit().
…iver_guiding_trajectory() and edited docstrings.
…es/beam_physics.py.
…he energy depletion is too severe.
…ithout driver guiding.
…ield used for driver guiding in abel/classes/stage/impl/stage_hipace.py.
Collaborator
|
Merge from master before today's meeting? |
ben-c-2013
commented
May 29, 2026
ben-c-2013
commented
May 29, 2026
ben-c-2013
left a comment
ben-c-2013
left a comment
Collaborator
Author
There was a problem hiding this comment.
Changes to be done...
…/abel/utilities/beam_physics.py::length2num_beta_osc.
…e.phase_advance_beta_evolution().
….driver_num_half_beta_osc.
…ed_beta_function(). This takes into account any external focusing gradient.
…vance_integrate_betas.
…ocusing (set to False) and made corrections in docstring in Stage.)
ben-c-2013
marked this pull request as ready for review
May 30, 2026 00:06
kyrsjo
reviewed
Jun 1, 2026
kyrsjo
reviewed
Jun 1, 2026
kyrsjo
reviewed
Jun 1, 2026
Collaborator
|
I had a very very quick look, @carlandreaslindstrom should probably see more for the architechture stuff. |
Collaborator
|
Hmm, looking at the output here https://app.readthedocs.org/projects/abel/builds/32906630/ (expand the final command |
Collaborator
|
@ben-c-2013 As far as I can see, this is ready for merging. That allows us to clean up a lot of other PRs that depend on this. We can add further functionality in later PRs. |
Collaborator
Author
Apologies for my late reply. Yes, please go ahead when you are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the capability to tailor the length of
Stageaccording to desired number of betatron oscillations. Also includes tests, but these require PR #174.In addition, also includes functions for estimating the orbit of the drive beam when driver guiding with an external azimuthal magnetic field is applied to a drive beam with an anglar offset.