Repository navigation
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e037dbd78f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "source=vck-codex,target=/home/node/.codex,type=volume", | ||
| "source=vck-claude,target=/home/node/.claude,type=volume" |
There was a problem hiding this comment.
Isolate writable agent configuration per container
Because these globally named volumes mount the entire writable Codex and Claude configuration directories, an agent in one untrusted clone can persist user-level settings that are then loaded by every CLI or IDEA container on the machine. In particular, Claude user settings apply to every project and can define hooks, so a modified settings.json can execute commands when a later session opens an otherwise clean checkout (Claude settings scope). Scope these volumes with ${devcontainerId} or share only narrowly isolated authentication state rather than the full configuration directories.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,55 @@ | |||
| FROM node:24-bookworm-slim | |||
There was a problem hiding this comment.
Force an amd64 image for Android builds
On Apple Silicon and other ARM64 hosts, this unqualified base image resolves to Linux ARM64, but the installed Android Linux SDK/build-tools contain unsupported x86-64 native binaries; Android explicitly states that ARM-based Linux CPUs are unsupported (Android Linux requirements). The image can build because sdkmanager is Java-based, then Android resource/build tasks fail with an executable-format error. Pin the dev-container image/build platform to linux/amd64 so Docker uses emulation on ARM hosts.
Useful? React with 👍 / 👎.
| bubblewrap ca-certificates curl git jq less nano openjdk-17-jdk-headless procps ripgrep tzdata \ | ||
| unzip vim \ |
There was a problem hiding this comment.
Install the libraries required by the IntelliJ backend
When a developer follows the documented Remote Development path, this slim image lacks the X11/runtime libraries required to start the IntelliJ backend, including libxext, libxrender, libxtst, and libxi. JetBrains lists these as Dev Container dependencies to install when the backend does not start (JetBrains Dev Container prerequisites). Add their Debian packages to this installation layer; otherwise the CLI workflow works while the advertised IDEA workflow fails during backend startup.
Useful? React with 👍 / 👎.
| JVM tests and build the Android library in the container. The image disables Apple targets and does not | ||
| include an Android emulator. | ||
|
|
||
| From the root of a regular Git checkout, with Docker running and Node.js and npm installed on the host, run |
There was a problem hiding this comment.
Document the native toolchain required by npx
On a clean host with exactly the listed prerequisites—Docker, Node.js, and npm—the first npx @devcontainers/cli invocation can fail while building its native node-pty dependency because Python and a C/C++ build toolchain are absent. The Dev Container CLI's own npm installation instructions explicitly require Python and C/C++ (Dev Container CLI README). Add those host prerequisites or use the CLI's standalone installer so the documented bootstrap works on a fresh machine.
Useful? React with 👍 / 👎.
No description provided.