Skip to content

Add dev containers for agent isolation - #806

Open
nodh wants to merge 1 commit into
developfrom
feature/dev-containers
Open

nodh wants to merge 1 commit into
developfrom
feature/dev-containers

Conversation

@nodh

@nodh nodh commented Nov 19, 2026

Copy link
Copy Markdown
Member

No description provided.

@nodh nodh self-assigned this Nov 19, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T11:44:16.933334Z e037dbd PR opened
🔒 Security Review ✅ Completed 2026-11-19T11:42:17.848329Z e037dbd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e037dbd78f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +14 to +15
"source=vck-codex,target=/home/node/.codex,type=volume",
"source=vck-claude,target=/home/node/.claude,type=volume"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Isolate writable agent configuration per container

Because these globally named volumes mount the entire writable Codex and Claude configuration directories, an agent in one untrusted clone can persist user-level settings that are then loaded by every CLI or IDEA container on the machine. In particular, Claude user settings apply to every project and can define hooks, so a modified settings.json can execute commands when a later session opens an otherwise clean checkout (Claude settings scope). Scope these volumes with ${devcontainerId} or share only narrowly isolated authentication state rather than the full configuration directories.

Useful? React with 👍 / 👎.

Comment thread .devcontainer/Dockerfile
@@ -0,0 +1,55 @@
FROM node:24-bookworm-slim

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Force an amd64 image for Android builds

On Apple Silicon and other ARM64 hosts, this unqualified base image resolves to Linux ARM64, but the installed Android Linux SDK/build-tools contain unsupported x86-64 native binaries; Android explicitly states that ARM-based Linux CPUs are unsupported (Android Linux requirements). The image can build because sdkmanager is Java-based, then Android resource/build tasks fail with an executable-format error. Pin the dev-container image/build platform to linux/amd64 so Docker uses emulation on ARM hosts.

Useful? React with 👍 / 👎.

Comment thread .devcontainer/Dockerfile
Comment on lines +19 to +20
bubblewrap ca-certificates curl git jq less nano openjdk-17-jdk-headless procps ripgrep tzdata \
unzip vim \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Install the libraries required by the IntelliJ backend

When a developer follows the documented Remote Development path, this slim image lacks the X11/runtime libraries required to start the IntelliJ backend, including libxext, libxrender, libxtst, and libxi. JetBrains lists these as Dev Container dependencies to install when the backend does not start (JetBrains Dev Container prerequisites). Add their Debian packages to this installation layer; otherwise the CLI workflow works while the advertised IDEA workflow fails during backend startup.

Useful? React with 👍 / 👎.

Comment thread DEVELOPMENT.md
JVM tests and build the Android library in the container. The image disables Apple targets and does not
include an Android emulator.

From the root of a regular Git checkout, with Docker running and Node.js and npm installed on the host, run

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the native toolchain required by npx

On a clean host with exactly the listed prerequisites—Docker, Node.js, and npm—the first npx @devcontainers/cli invocation can fail while building its native node-pty dependency because Python and a C/C++ build toolchain are absent. The Dev Container CLI's own npm installation instructions explicitly require Python and C/C++ (Dev Container CLI README). Add those host prerequisites or use the CLI's standalone installer so the documented bootstrap works on a fresh machine.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant