Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: cc6e8aaac5
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
| // presented as a whole, its claims are not selectively disclosable (OpenID4VP 1.0, 6.4.1) | ||
| CreatePresentationResult.VcJws(credential.vcSerialized) |
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Security: Reject filtered requests for non-selective VCs
When a wallet holds a PLAIN_JWT with claims beyond the accepted DCQL filter, this branch now serializes the complete stored credential despite the matching result identifying only requested claims. The removed guard previously rejected this case. Consequently, an accepted but overreaching verifier can request a benign claim and receive every claim in the signed VC, bypassing the consent flow documented as showing the matches before finalization. Keep rejecting filtered queries unless consent explicitly covers disclosure of the complete credential.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
sounds serious to me
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc6e8aaac5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val alreadyQualified = firstSegment is OpenId4VciClaimsPathPointerSegmentString && | ||
| firstSegment.string == VcDataModelConstants.CREDENTIAL_SUBJECT | ||
| return if (alreadyQualified) this | ||
| else copy(path = OpenId4VciClaimsPathPointer(VcDataModelConstants.CREDENTIAL_SUBJECT) + path) |
There was a problem hiding this comment.
Preserve already-rooted VC claim descriptions
When a VC-JWT scheme—particularly an ExtractedVcJwtCredentialScheme built from type metadata—already supplies a root-level path such as ["issuer"] or ["type"], this unconditionally rewrites it to ["credentialSubject", "issuer"] or ["credentialSubject", "type"]. Claims path pointers apply to the credential root (OpenID4VCI Appendix C), so the rewritten issuer metadata advertises nonexistent claims, and a mandatory root claim makes CredentialScheme.requiredClaims reject otherwise valid credentials. Preserve explicitly qualified VC-root paths, for example with a qualification flag analogous to isoClaimPathsAreQualified, while still qualifying subject-relative paths for shared multi-format schemes.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
sounds equally serious
| val namespaces = (requestedMdocClaims + requestedOptionalMdocClaims) | ||
| .groupBy({ it.namespace }, { SingleItemsRequest(dataElementIdentifier = it.claimName, intentToRetain = false) }) |
There was a problem hiding this comment.
Keep optional mdoc attributes from blocking credential matches
When optionalAttributePaths contains an element that a holder's mdoc does not contain, adding it to the DocRequest here makes the otherwise suitable credential fail matching. DeviceRetrievalProcedure.evaluateItemsRequestAgainstCredential explicitly requires every entry in ItemsRequest.namespaces and throws for a missing element, so the response path never reaches the claimed missing-element error handling; the wallet instead reports no matching credential even when every required attribute is present. Either omit optional attributes from direct ISO requests or extend the matching and response pipeline to represent absent requested elements without rejecting the credential.
Useful? React with 👍 / 👎.
JesusMcCloud
left a comment
There was a problem hiding this comment.
ping me, if this is not reviewed by Thursday 10 a.m.
cc6e8aa to
7a3eec2
Compare
|
@codex review again |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
d4c4fed to
7f9ccf2
Compare
Cite the RFC 9901 steps each check implements, distinguish a disclosure supplied twice (4) from a digest occurring twice (7.1 step 4), and cite never-disclosable claims to draft-ietf-oauth-sd-jwt-vc-19, 2.2.2.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The OpenID4VP 7.3 example tests and the serialization conformance tests of DCQLClaimsPathPointer cover the same behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ISO/IEC 18013-5 requests a data element by its name space and data element identifier (2021, 8.3.2.1.2.1). RequestOptionsCredential interpreted the claims path pointers of an ISO_MDOC request twice: toDocRequest() ignored pointers with three or more names and the optional ones, while the DCQL builder threw on the former and put a lone identifier into the name space "mdoc" when the scheme had none. RequestOptionsCredential now reads them once, when constructed, as requestedMdocClaims and requestedOptionalMdocClaims, rejecting any other shape, and both builders use only those. toDocRequest() still requests only the required data elements, as a DocRequest marks none as optional (8.3.2.1.2.1). toIsoMdocClaimPath and toSingleItemsRequest are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WRPRC authorization exempted only the root vct claim. Exempt every claim that draft-ietf-oauth-sd-jwt-vc-19, 2.2.2.3 forbids to be selectively disclosed (iss, nbf, exp, cnf, vct, vct#integrity, aka_vcts, status), including their sub-claims, since the holder can not withhold them. sub, iat, and nested claims of these names must still be registered. Share the claim set with SdJwtEvaluation. As the exemption relies on the holder not withholding sub-claims, processDisclosures rejects a disclosure anywhere below these claims, as an object property or an array element, not only of the claims themselves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DCQL claims paths for W3C VCs match on the root of the VC (OpenID4VP 1.0, B.1.2), e.g. ["credentialSubject", "given_name"], instead of on a flattened credential subject: - CredentialToJsonConverter returns the VC itself for VC-JWTs - CredentialPresentationRequestBuilder prefixes credentialSubject to VC-JWT attribute paths (toVcJwtClaimPath) - Required claims of VC-JWT types are qualified the same way (vcJwtQualifiedClaimDescriptions), unless the scheme's paths start at the VC root already (vcJwtClaimPathsAreQualified), as for schemes derived from type metadata, so they may name e.g. ["issuer"] - A VC-JWT is presented as a whole also if claims are requested, since its claims are not selectively disclosable (OpenID4VP 1.0, 6.4.1). DCQLCredentialQuery.match reports it as AllClaimsMatchingResult, so a wallet asking for consent shows that every claim is disclosed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claims paths point into the VC (OpenID4VCI 1.0, C), so jwt_vc_json credential configurations advertise ["credentialSubject", "given_name"] instead of ["given_name"]. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7f9ccf2 to
6ceefa9
Compare
Some more fixes to our internal claim path structure and handling, to prepare for a refactoring.