[matpala]

The drivers module was always built in Debug, even when the firmware was ReleaseSmall.

[Grazfather]

Shouldn’t we take the options.assert in drivers/build as well?

…

On Tue, Oct 20, 2026 at 8:39 AM matpala ***@***.***> wrote: the ´drivers' module was allways built in Debug, even when the firmware was ReleaseSmall ------------------------------ You can view, comment on, or merge this pull request online at: #1096 Commit Summary - da405b7 <da405b7> build: compile the drivers module with the firmware's optimize mode File Changes (2 files <https://github.com/ZigEmbeddedGroup/microzig/pull/1096/files>) - *M* build.zig <https://github.com/ZigEmbeddedGroup/microzig/pull/1096/files#diff-f87bb3596894756629bc39d595fb18d479dc4edf168d93a911cadcb060f10fcc> (5) - *M* drivers/build.zig <https://github.com/ZigEmbeddedGroup/microzig/pull/1096/files#diff-9082ae5e8d73fc722547fb83340d2bd8fac917eeb32f845310e19332f11aeae3> (2) Patch Links: - https://github.com/ZigEmbeddedGroup/microzig/pull/1096.patch - https://github.com/ZigEmbeddedGroup/microzig/pull/1096.diff — Reply to this email directly, view it on GitHub <#1096?email_source=notifications&email_token=AADZNHX6BWLJSZNRUOLJPTD5U5MHVA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42DSMZVHAZTSNRZHGTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVRTG633UMVZF6Y3MNFRWW>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZNHQFXTTQ6TFSLDUT4335U5MHVAVCNFSNUABFKJSXA33TNF2G64TZHMZTIOJRGM2DIMRWHNEXG43VMU5TKOJUGE3TONBQGA22C5QC> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AADZNHSDAVF74V2ESTKXCOL5U5MHVA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42DSMZVHAZTSNRZHGTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVJTG633UMVZF62LPOM> and Android <https://github.com/notifications/mobile/android/AADZNHSEKLLMX55PIVEWJ635U5MHVA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42DSMZVHAZTSNRZHGTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVZTG633UMVZF6YLOMRZG62LE>. Download it today! You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[mattnite]

I don't think we need this? AFAIU, all modules inherit the target and optimize of the root module

[matpala]

@mattnite that only applies when the module's optimize is null. drivers/build.zig sets it with b.standardOptimizeOption(.{}), which is Debug here because the dependency gets no optimize option. On main, the ReleaseSmall build shows -Odebug for drivers; with this PR it's -Osmall. The .text of rf-nano-v3_spi_nrf24 goes from 1968 to 1948 bytes.

@Grazfather asserts is already passed since #1077: add_firmware has .asserts = options.asserts.

I also reverted passing optimize to link. The network module asks for it with .{}, so the different arguments made two modules for the same file and broke the rp2xxx net examples.