Repository navigation
Fix WiFi cyw43439 bugs introduced in 91773f57 - #1093
Merged
mattnite merged 2 commits intoOct 18, 2026
Merged
Conversation
Grazfather
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both bugs were introduced in 91773f5 ("Update code for new @bitcast semantics"). On a Pico 2 W running
net-pong, the first made every event get dropped, so the join timed out. The second made every data frame get dropped, so DHCP never completed.ioctl.zig: skip BDC padding inResponseSince the port,
Response.data()returnsreader.buffer[seek..end], butbdc()consumed only the BDC header and not theoffset * 4padding after it. For events withbdc.offset != 0the payload started too early,event()returnednull, and all events were dropped.bdc()now also discards the padding.data()is unchanged, and a bogus offset leavesdata()empty. Added a regression test with a captured event packet.wifi.zig:send_zcbus write startsend_zcpassedas_words(writer.buffered(), …), which starts atbuffer + 4, sobus.write's command word overwrote the SDPCMlen/not_lenand the chip dropped every data frame. It now passesas_words(buffer, words_len)again, as before the port.Verified on a Pico 2 W with
net-pong: the join succeeds, DHCP leases an address, and the board answers ping.