Repository navigation
ops: immutable client releases, main-only release builds, SHA-pinned actions - #196
Merged
Merged
Conversation
…actions - release-clients: no --clobber; a release that already has files fails with a clear message. Python builds stamped with SOURCE_DATE_EPOCH from the tagged commit; TypeScript and Python jobs build twice and compare. - The release MCP tarball bundles @zero-state/jchain (bundleDependencies) in the runner's copy only; the job checks it installs alone and the bundled copy matches the released client tarball. MCP README and the release notes now install the one file. - versions job fails a clients-v tag whose commit is not on main. - Every third-party action pinned to a commit SHA with a version comment; dependabot keeps them current weekly. - RUNBOOK: client release rules and a recommended clients-v* tag ruleset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8SjVSu8au2USqFDpkD1Li
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three findings from the independent review of PRs #182 to #194. Workflows, MCP packaging in the release job, the MCP README, and docs/RUNBOOK.md only. No spec version bump.
A. Release files can be replaced; the MCP tarball's client dependency was unchecked
gh release upload --clobberis gone. If the release for the tag already has files, thereleasejob fails with "Releases are immutable ... bump the client version and push a new clients-v tag". A release opened by hand with no files still gets them attached (without--clobber).SOURCE_DATE_EPOCHset to the tagged commit's time. npm pack already writes a fixed mtime on every entry, so it needs none. The TypeScript and Python jobs now build twice andcmpthe results, so reproducibility is checked on every run.@zero-state/jchain(bundleDependencies, with the dependency pinned to the exact version). Only the runner's copy ofclients/mcp/package.jsonandnode_moduleschanges; the repo's dev setup (link to../typescript) is untouched, sonpm ciand clients-ts are unaffected. The job checks the tarball contains the client, installs it alone in a scratch dir, checks the lockfile has noreleases/downloadURL and marks the clientinBundle, and imports the server. A newassetsjob checks the bundled copy is byte for byte the released client tarball, writesSHA256SUMSand the notes, and emits aRelease assetnotice per file (name, size, SHA-256). It runs on manual dispatch too.B. A release could be built from any commit
versionsjob checks out withfetch-depth: 0, fetchesmain, and fails a tag push unlessgit merge-base --is-ancestor "$GITHUB_SHA" origin/main. A manual run on a branch only gets a notice, since it publishes nothing.clients-v*tag ruleset (Danny's to set).C. Actions were pinned to major tags
Every
uses:across the ten workflows is pinned to a full commit SHA with a# vX.Y.Zcomment, the latest release within the major already in use (majors unchanged). The SHAs come from GitHub's tag refs (git ls-remote --tags; annotated tags taken from their peeled^{}commit). Each one matches the moving major tag.3d3c42e5aac5ba805825da76410c181273ba90b111d5960a326750d5838078e36cf38b85af67726249933ea5288caeca8642d1e84afbd3f7d6820020ea165f8d65b6e75b540449e92b4886f43607fa02d3f86a106a0bac45b974a628896c90dbdf5c8093a26af69be951a213d495a4c3e4e4022e16d8706521c1be1b93ad9ed58fa840aacc3f279cde2a72ffe7477775783ea5526144ba13e8db5eec57747ce8.github/dependabot.ymladds thegithub-actionsecosystem, weekly, grouped into one PR.For Danny
clients-v*(restrict create, update, delete).Generated by Claude Code