feat(terminal): add the YourSSH Dark color theme - #106
Merged
Merged
Conversation
The catalog shipped 44 community schemes and none of the app's own, so the first picker entry -- and the theme terminalThemeByName falls back to for an unknown name -- was somebody else's palette. Add YourSSH Dark at index 0: neutral charcoal base, deliberately desaturated ANSI set so long log output stays flat, azure/teal on the cursor, selection and current search hit. SettingsProvider's stored default stays Dracula, so no existing install changes appearance. Also capture the picker dialog in the screenshot harness. Closes #105
8 of 13 tasks
…rminal-theme-yourssh-dark # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 45th terminal color scheme, "YourSSH Dark", as the app's own and places it first in the catalog. Neutral charcoal base, deliberately desaturated ANSI set so long log output stays flat and readable, azure/teal accents on the cursor, selection and current search hit.
Closes #105.
Changes
_yourSshDarkinapp/lib/theme/terminal_themes.dart— all 23 fields (background/foreground/cursor/selection, 8 normal + 8 bright ANSI, 3 search-hit colors), registered askTerminalThemes[0]. No other theme is touched.terminalThemeByNameresolves to for an unknown name (e.g. a theme id arriving from sync that this build does not have).SettingsProvider's stored default staysDracula, so no existing install changes appearance on upgrade.YourSSH Dark leads the catalog and is the fallback theme. The pre-existing invariants (semi-transparent selection per [Bug UI] Highlight/Selection color is too dark and unreadable in the HOST terminal tab #40, unique names) now cover the new entry too — its selection is#2E4A57atAA.[Unreleased] → Added.feature_screenshots_test.dartnow opens the theme picker dialog and captures it (05-settings/05-terminal-theme-picker.png), closing it with Esc so the following scroll steps still hit the settings scroll view.Palette
#1A1D20#1F2225#4E545C#C9CCD1#CF6A6A#E08A8A#56B6D8#7CB07A#97C795#2E4A57@AA#D6A15C#E8BC7A#D6A15C#5A9BD4#7DB4E3#5A9BD4#A98BC9#C2A6DD#1A1D20#5FB3B8#7FCBCF#B8BCC2#E8EAEDType of change
feat— new featurefix— bug fixrefactor/polish— no behavior changedocs— documentation onlytest— tests onlyrelease— version release tomasterHow was this tested?
cd app && flutter analyze— no new warningscd app && flutter test— all tests pass (1722)Beyond the widget tests, the theme was checked against a live local shell driven by an integration test and verified by sampling rendered pixels, not by eye — background and all six sampled ANSI colors match the palette exactly (magenta reads
#A88AC8on some samples from text antialiasing).Screenshots
The picker with the new entry first, and the "45 themes" counter:
Checklist
Note for the reviewer
develop's README/CHANGELOG do not yet carry these two doc lines, so this PR adds them. The same two lines were also swept intorelease/0.2.0's commit14fdbed(they were sitting uncommitted in the tree when that release commit was made), so expect a trivial same-content conflict whenrelease/0.2.0merges back intodevelop.