Repository navigation
Conversation
馃 Changeset detectedLatest commit: 11876c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastOfUnionimplies an ordering that unions do not guarantee. AddMemberOfUnionwith the exact existing selection algorithm and keepLastOfUnionas a deprecated compatibility alias, preserving its source path and both public package exports. Document unspecified, compiler-dependent selection andneverbehavior.UnionToTupleuses the new name with unchanged recursion; its example and tests no longer promise an order.Add compiled assertions for a non-never single member, singleton/empty unions, booleans, collapsed unions, alias compatibility, tuple membership/length, and types/core imports. Add one package-neutral Changesets note for types and core. Changesets also plans a dependent utils patch; no versions or historical changelogs were edited. The new API uses
@since @nextpending release versioning.Validation on Windows, Node 24.19.0 / pnpm 11.22.0 / TypeScript 7.0.2:
tsc --ignoreConfig --noEmit --target ES2024: ESNext/bundler with the dev-source condition, plus ESNext/bundler and NodeNext/NodeNext with built public exports. Zero diagnostics or unresolved imports; no suppressions, path aliases, or skipLibCheck. These checks compile assertions independently of main's existing Vitest discovery gap.pnpm auditfails on the unchanged dependency graph: 17 advisories, comprising three critical, four high, nine moderate, and one low. This exceeds CORE-02's older snapshot and remains outside this change.Independent branch from main
e195ff7d9aca4e702b098744a52d5ca29bd3e9cc; head2b963309e902eeb01e88a959ccfac4d536915051. No CORE-25 optimization, test-discovery configuration, enum assertions, or unrelated audit fixes. PRs #16/#17/#18 are untouched; HQ should reconcile their overlapping union tests/JSDoc and run independent review. No external reviews or merge actions requested.Review follow-up at
11876c29af8f45216b66d2e7c210491a32d20963: replace the permissive tuple assignability probes withIsDisjointUnion<Actual> === falsefor literal and boolean unions. Direct strict compiler checks pass in the three source/built modes above. Temporary whole-union and boolean replacements each produce the expected TS2344 error, proving the assertions reject that regression. Formatting and whitespace checks pass. Clarify that member selection may differ between compiler versions and programs. The selection algorithm, alias and package configuration are unchanged; the earlier full-suite results remain scoped to2b96330.PR #17 owns the separate UnionToTuple order-clarification release note and enum-helper removal. Reconcile its JSDoc plus PR #16's test changes when landing this PR after them. Replace MemberOfUnion's
@since @nextwith the actual version when the Changesets release PR establishes it; no release version is guessed here. Opus correctness and Sonnet documentation re-reviews are complete at11876c2, with no new findings. Both independently reproduced the negative assertions and direct compiler checks. CI passes every validation step except the unchanged dependency audit.