Repository navigation
Keep mirroring order books that hold orders which never expire - #54
Merged
Merged
Conversation
Counterparty Core now returns open orders with expiration 0 and expire_index null. orders.expire_index was NOT NULL, so one such order failed its market's whole write and sync_orders errored on every run, leaving those books stale. Migration 0040 rebuilds orders with a nullable expire_index, copying every row and recreating both indexes. The indexer stores null for an order that never expires (and still dates an expiring order Core sends without expire_index), the read route passes it through, and the activity, asset and profile order lists show "No expiry" instead of a countdown or "GTC". The label is machine-translated in every locale and listed as such in each status file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterparty Core now returns open orders with expiration 0 and
expire_index null. orders.expire_index was NOT NULL, so one such order
failed its market's whole write and sync_orders errored on every run,
leaving those books stale.
Migration 0040 rebuilds orders with a nullable expire_index, copying
every row and recreating both indexes. The indexer stores null for an
order that never expires (and still dates an expiring order Core sends
without expire_index), the read route passes it through, and the
activity, asset and profile order lists show "No expiry" instead of a
countdown or "GTC". The label is machine-translated in every locale and
listed as such in each status file.