Repository navigation
Put P2TR and P2WSH reward recipients in the MPMA from tip 971,699 - #52
Merged
Merged
Conversation
Core applies mpma_taproot_support to the block after its tip, which is the earliest block a send can land in, so a send composed at tip 971,699 already lands in 971,700 or later. mpmaCapable now allows every destination once tip + 1 reaches the activation; an unknown tip keeps the pre-activation split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #48. Core applies
mpma_taproot_supportto the block after its tip, and that is the earliest block a send composed now can land in. A reward send composed when the tip is 971,699 therefore lands in 971,700 or later, and Core's compose already accepts 32-byte programs.scripts/lib/mpma.mjs:mpmaCapablereturns true for every destination oncetip + 1 >= 971,700. If the tip is unknown (NaN or not an integer), the old packed-length rule still applies.scripts/reward-batch.mjs: the header comment now says the same.tests/mpma-capable.test.ts: tips 971,698 and 969,320 still send P2TR/P2WSH to manual. Tips 971,699, 971,700 and 971,701 take every address. An unknown tip keeps the old split.Gates run locally:
npm run check(111 files, 1426 tests, typecheck, lint, numeric, i18n) andnext build. No api code changed, so there was no wrangler dry run.