Repository navigation
Preserve exact transaction drafts and finish Launchpad localization - #21
Merged
Merged
Conversation
…rrectness # Conflicts: # apps/web/src/locales/es.status.json # apps/web/src/locales/fr.status.json # apps/web/src/locales/ja.status.json # apps/web/src/locales/ko.status.json # apps/web/src/locales/pt.status.json # apps/web/src/locales/ru.status.json # apps/web/src/locales/uk.status.json # apps/web/src/locales/zh-hk.status.json # apps/web/src/locales/zh-tw.status.json # apps/web/src/locales/zh.status.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep transaction amounts intact while localizing the site. Invalid drafts such as
-5,1e5, or0,5remain visible and block quotes or compose instead of becoming a different valid amount. Amount, fee, and slippage controls validate their complete draft; generated Max values and compose quantities use canonical digits, a decimal point where supported, and the asset’s verified precision.Language, number format, and fiat currency are separate saved preferences. Number formatting follows the interface language by default and supports an independent override. Currency Auto uses browser regional preferences; an explicit choice, including USD, survives language changes. Presentation changes do not reinterpret transaction values. Current fiat estimates use the selected currency with dated rate context; historical values retain their USD basis.
Use the local Rewards label without XCP in non-English navigation and page titles; currencies remain identified beside amounts. Finish the localized navigation, canonical/hreflang metadata, translation coverage, and source-context review. Correct transaction, expiry, refund, LP-token, and funding explanations against the actual components and Counterparty semantics, with primary crypto terminology references. AI-reviewed translations retain machine provenance; this does not claim native-speaker approval. Language switching navigates to another URL and currently clears unsaved form drafts.
Validation:
The immutable SDK pin
79f190308d4b60cc3ec9023beada21e0ee776213already passes its CI and builds; a new SDK release is unnecessary. The API tree matches merged PR24, so this localization release needs only the web deployment.