Repository navigation
Fix inscription payloads and preserve uploads through review - #583
Merged
Merged
Conversation
droplister
force-pushed
the
codex/fix-inscription-forms
branch
from
October 11, 2026 18:04
7961d78 to
79cd29a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inscribe could submit a filename as an ordinary asset description, reject a Fairminter request because its inscription flag contained text, or lose a selected file when returning from review. These defects also reproduce in the pre-audit forms.
description, with the MIME type,inscription=true, and Taproot encoding. Fairminter uses the same boolean flag with its text description.inscriptionis a boolean query parameter, not base64 content.Verified against the running Counterparty Core 11.5.0 image, including its
composer.CONSTRUCT_PARAMSandapiserver.parse_bool_arg. Core's compose API carries inscription content in description/text and distinguishes textual from binary MIME types.Validation:
src/pages/compose/inscription-forms.test.tsx).e2e/regtest/inscription-forms.test.ts). The existing issuance, Fairminter, Taproot and provider-bundle suites also passed 26 cases, with two pre-11.5 cases skipped.Builds on #582, now merged. Rebased onto main with an identical resulting source tree.