Skip to content

Fix inscription payloads and preserve uploads through review - #583

Merged
droplister merged 1 commit into
mainfrom
codex/fix-inscription-forms
Oct 11, 2026
Merged

droplister merged 1 commit into
mainfrom
codex/fix-inscription-forms

Conversation

@droplister

@droplister droplister commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Inscribe could submit a filename as an ordinary asset description, reject a Fairminter request because its inscription flag contained text, or lose a selected file when returning from review. These defects also reproduce in the pre-audit forms.

  • Update Description sends file contents in description, with the MIME type, inscription=true, and Taproot encoding. Fairminter uses the same boolean flag with its text description.
  • Issuance, Update Description, and Broadcast share upload state handling. Returning from review restores content, MIME type, filename, and inscription mode. Removing or rejecting a file blocks submission; selecting ordinary text clears inscription metadata and does not expose binary hex in the text field.
  • Correct the option comments: inscription is a boolean query parameter, not base64 content.

Verified against the running Counterparty Core 11.5.0 image, including its composer.CONSTRUCT_PARAMS and apiserver.parse_bool_arg. Core's compose API carries inscription content in description/text and distinguishes textual from binary MIME types.

Validation:

  • 472 focused unit tests passed. The 20 form tests cover text/binary round trips, replacement/removal, ordinary-text mode, oversized files, read errors, and Fairminter flags; 18 fail against the original forms (src/pages/compose/inscription-forms.test.tsx).
  • Four browser checks passed for issuance/broadcast Back navigation and file uploads.
  • Five targeted regtest cases passed with Core 11.5.0 and Bitcoin Core 30: the broken payloads reproduce the wrong ledger descriptions or boolean error, and the intended issuance/Fairminter inscriptions pass wallet verification, signing, mempool acceptance, mining, and ledger readback (e2e/regtest/inscription-forms.test.ts). The existing issuance, Fairminter, Taproot and provider-bundle suites also passed 26 cases, with two pre-11.5 cases skipped.
  • Typecheck, lint (existing warning budgets), production build, and E2E build passed.

Builds on #582, now merged. Rebased onto main with an identical resulting source tree.

@droplister
droplister changed the base branch from codex/compose-form-state to main October 11, 2026 18:04
@droplister
droplister force-pushed the codex/fix-inscription-forms branch from 7961d78 to 79cd29a Compare October 11, 2026 18:04
@droplister
droplister merged commit 1a46cba into main Oct 11, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant