Validate SAV missing-value count before abs() - #395
Merged
Merged
Conversation
OSS-Fuzz 471515730 (fuzz_format_sav): readstat_parse_sav reported a
signed integer overflow in sav_skip_variable_record. The variable
record's n_missing_values field is attacker-controlled, and
abs(n_missing_values) * sizeof(double)
is undefined when n_missing_values is INT_MIN (negating -2147483648
overflows int). Apply the same -3..3 bound that
sav_read_variable_missing_values already enforces before taking the
absolute value, rejecting the record as a parse error otherwise.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VbdjJ6i4dby3R6KM6m4Rpi
evanmiller
force-pushed
the
fix-sav-missing-values-overflow
branch
from
September 13, 2026 18:58
2a6fec4 to
1346997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSS-Fuzz 471515730 (fuzz_format_sav): readstat_parse_sav reported a signed integer overflow in sav_skip_variable_record. The variable record's n_missing_values field is attacker-controlled, and
is undefined when n_missing_values is INT_MIN (negating -2147483648 overflows int). Apply the same -3..3 bound that
sav_read_variable_missing_values already enforces before taking the absolute value, rejecting the record as a parse error otherwise.
Claude-Session: https://claude.ai/code/session_01VbdjJ6i4dby3R6KM6m4Rpi