feat: surface chunk response transport metadata - #32
Open
dirvine wants to merge 2 commits into
Open
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue
Closes V2-903
Risk tier
Compatibility
ChunkProtocolResponseenvelope andsend_and_await_chunk_response_with_metadata; the existing helper remains as a compatibility wrapper.Semver impact
Test evidence
cargo fmt --all -- --check— passed.cargo clippy --all-targets --all-features -- -D warnings— passed.cargo test --all-features -- --test-threads=1— passed: 79 tests.cargo build --no-default-features— passed.Current stacked-PR status: the publish dry-run is expected to remain red until saorsa-core #162 is released and this PR switches from the temporary git override to that released version. All other current checks pass.
New dependency
none. This PR temporarily follows the branch from WithAutonomi/saorsa-core#162 so the stack is testable; replace it with that crate's released version before merge.
ADR
n/a — the change exposes metadata already present on received events and does not alter the wire protocol or response acceptance.
Mitigation / rollback
Revert this commit; existing callers continue through the unchanged compatibility helper.