Repository navigation
Conversation
…C validation; bump version to 3.2.0
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The Shopify webhook signature verification change has no active review issues.
No open issues 🎉
What changed in this PR
Adds Shopify webhook signature verification to the existing OAuth utilities and prepares package version 3.2.0.
Changes:
- Adds HMAC-SHA256 verification for raw byte and string bodies using constant-time hash comparison.
- Exposes the Shopify webhook HMAC header name and documents raw-body requirements.
- Adds tests for valid signatures, tampered bodies, malformed headers, encoding, and null inputs.
| File | Description |
|---|---|
| ShopifyNet/ShopifyNet.csproj | Bumps the package version from 3.1.0 to 3.2.0. |
| ShopifyNet/OAuth/ShopifyOAuthClient.cs | Adds webhook HMAC verification overloads and the header-name constant. |
| ShopifyNet.Tests/ShopifyWebhookHmacTests.cs | Adds webhook signature validation and edge-case tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.