Repository navigation
Feat/pass accesstoken to request httpheaders - #24
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new request-token bucket selection lacks unit tests for shared buckets, token isolation, and null-token fallback, leaving cross-token rate-limit regressions uncovered.
1 open issue
What changed in this PR
This PR prepares ShopifyNet 3.0.0 for per-request access tokens and GraphQLSharp’s header-callback API. Custom interceptors remain responsible for applying request tokens to HTTP headers.
Changes:
- Add an optional request access token and use it to select the rate-limit bucket.
- Update interceptor delegates to support header callbacks.
- Bump ShopifyNet and GraphQLSharp to version 3.0.0.
| File | Description |
|---|---|
| ShopifyNet/ShopifyNet.csproj | Bumps the package version to 3.0.0. |
| ShopifyNet/ShopifyGraphQLRequest.cs | Adds and documents the optional per-request token. |
| ShopifyNet/Interceptor/TokenBucket/TokenBucketInterceptor.cs | Selects buckets by request token and adopts the new delegate. |
| ShopifyNet.Tests/TokenBucket/TestInterceptor.cs | Forwards header callbacks through the test interceptor. |
| Directory.Packages.props | Upgrades GraphQLSharp to 3.0.0. |
Review effort: Balanced
matnun-br
marked this pull request as ready for review
November 13, 2026 06:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.