Skip to content

Feat/pass accesstoken to request httpheaders - #24

Merged
matnun-br merged 3 commits into
mainfrom
feat/pass-accesstoken-to-request-httpheaders
Nov 13, 2026
Merged

matnun-br merged 3 commits into
mainfrom
feat/pass-accesstoken-to-request-httpheaders

Conversation

@matnun-br

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new request-token bucket selection lacks unit tests for shared buckets, token isolation, and null-token fallback, leaving cross-token rate-limit regressions uncovered.

1 open issue
What changed in this PR

This PR prepares ShopifyNet 3.0.0 for per-request access tokens and GraphQLSharp’s header-callback API. Custom interceptors remain responsible for applying request tokens to HTTP headers.

Changes:

  • Add an optional request access token and use it to select the rate-limit bucket.
  • Update interceptor delegates to support header callbacks.
  • Bump ShopifyNet and GraphQLSharp to version 3.0.0.
File Description
ShopifyNet/​ShopifyNet.csproj Bumps the package version to 3.0.0.
ShopifyNet/​ShopifyGraphQLRequest.cs Adds and documents the optional per-request token.
ShopifyNet/​Interceptor/​TokenBucket/​TokenBucketInterceptor.cs Selects buckets by request token and adopts the new delegate.
ShopifyNet.Tests/​TokenBucket/​TestInterceptor.cs Forwards header callbacks through the test interceptor.
Directory.Packages.props Upgrades GraphQLSharp to 3.0.0.

Review effort: Balanced

@matnun-br matnun-br assigned clement911 and unassigned Copilot Nov 13, 2026
@matnun-br
matnun-br marked this pull request as ready for review November 13, 2026 06:04
@matnun-br
matnun-br merged commit caa36ad into main Nov 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants