Skip to content

fix: tighten route handling in the proxy layer - #1889

Merged
Wikid82 merged 4 commits into
developmentfrom
fix/proxy-route-handling
Nov 9, 2026
Merged

Wikid82 merged 4 commits into
developmentfrom
fix/proxy-route-handling

Conversation

@Wikid82

@Wikid82 Wikid82 commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

Tightens route handling in the proxy layer. The recovery route for the reset endpoint is now generated only for a host that proxies Charon itself, and it matches only the two exact reset paths. Every other host and path goes through the full security pipeline.

Changes

  • backend/internal/caddy/config.go: recovery route limited to self-proxy hosts and exact paths.
  • Route-count and shape assertions updated (none removed); new tests pin the generated pipeline order and the recovery route.
  • ARCHITECTURE.md: proxy route section updated.
  • Playwright cases for route handling on an allow-listed host and a self-proxy host.

Validation

  • Backend build, vet, scoped tests, coverage gate (93.2%), patch coverage 100%, make lint-fast and make lint-backend: pass.
  • CodeQL Go: no new results; existing suppressions re-reviewed and still justified.
  • Throwaway-container check of the generated routes and the reset flow: pass.
  • Targeted Playwright (acl-enforcement): 9 of 9. lint:e2e at its ceiling.

Addresses the first item of the Cerberus hardening batch.

@github-advanced-security

Copy link
Copy Markdown
Contributor

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✅ Supply Chain Verification Results

✅ PASSED

📦 SBOM Summary

  • Components: 1873

🔍 Vulnerability Scan

Severity Count
🔴 Critical 0
🟠 High 0
🟡 Medium 13
🟢 Low 2
Total 16

📎 Artifacts

  • SBOM (CycloneDX JSON) and Grype results available in workflow artifacts

Generated by Supply Chain Verification workflow • View Details

@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Wikid82
Wikid82 merged commit 99e903c into development Nov 9, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants