TIGER-230: remove WebTigers marketing from tiger-core (core ships a neutral home) - #310
Merged
Merged
Conversation
…eutral home) Out of the box, the default IndexController now serves a neutral, brandable welcome stub. All WebTigers marketing collateral lives in the private WebTigers/TigerMarketing module, which re-adds it on WebTigers' own installs. Removed from core: - IndexController: the 10 marketing actions (vibe/agency/developers/creators/ hosting/features/get-tiger/saas-vs-sias/how-it-works/tech-stack) and the init() that appended marketing.css. The home-resolution chain stays intact. - configs/routes.ini: the 10 marketing pretty-route aliases (kept /user/profile). - core/views/scripts/index/*: 66 marketing view scripts + locale variants (kept the neutral index.phtml). - PUMA public-header: the "Why Tiger" and "Solutions" mega-menus + the Features link (kept Docs + GitHub) — the nav is neutral now. - PUMA default.css: the mega-menu (.tiger-mega/.tiger-mini) and marketing comparison-table (.cell-emphasis) blocks; assets/marketing.css deleted. - PUMA theme.php (all locales): the theme.mega.* and marketing theme.nav.* keys. The public surface now loads only barebones Bootstrap 5 + the JS libs. Tests: dropped the marketing-action dispatch tests; retargeted the SEO page-discovery and Social-cards tests to the one shipped view page (the neutral home, `index`). Proven on tiger-dev: / renders the neutral home (no marketing.css, no mega-menu), marketing URLs 404, /docs + /login 200. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
Per the design: with no theme or module active, core owns only index/index and it renders NOTHING. The public PUMA layout is stripped to a bare shell — core assets in <head> (Bootstrap + JS libs) and an empty <main>; no header, footer, menus, or skip-link. Chrome comes from a theme or a module (e.g. the private TigerMarketing), never bare core. - core/views/scripts/index/index.phtml: deliberately blank (was a welcome stub). - themes/puma/layouts/scripts/layout.phtml: removed the public-header, public-footer, and skip-link renders; kept the <head> asset/SEO registry, <main>, the JS libs, and the invisible-by-default GDPR consent hook. - core/languages/*/core.php: dropped the now-unused core.home.* keys. - .github/workflows/smoke.yml: updated the contract to match — /vibe and /agency now assert 404 (marketing left core), and the home is asserted to carry NO marketing chrome (mega-menu / audience links) instead of requiring it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
Brings PR #310 current with main (1.17.0), version → 1.18.0, CHANGELOG. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Core no longer ships WebTigers' marketing pages. Out of the box, the default-namespace
IndexControllerserves a neutral, brandable welcome stub; all WebTigers marketing collateral now lives in the private WebTigers/TigerMarketing module, which re-adds it (home + Solutions pages) on WebTigers' own installs.The public surface now loads only barebones Bootstrap 5 + the JS libs — no
marketing.css, no marketing chrome.Removed from core
IndexController— the 10 marketing actions (vibe/agency/developers/creators/hosting/features/get-tiger/saas-vs-sias/how-it-works/tech-stack) and theinit()that appendedmarketing.css. The home-resolution chain (indexAction/_forwardToPath/_homePageId) is untouched, so precedence is still ComingSoon → admin-chosen home → neutral stub.configs/routes.ini— the 10 marketing pretty-route aliases (kept the/user/profilealias). (Note: keeps all four env sections — the boot fatal that reminded me why.)core/views/scripts/index/— 66 marketing view scripts + locale variants (kept the neutralindex.phtml).public-header.phtml— the "Why Tiger" and "Solutions" mega-menus + the Features link. Nav is now just Docs + GitHub.default.css— the mega-menu (.tiger-mega/.tiger-mini) and marketing comparison-table (.cell-emphasis) blocks;assets/marketing.cssdeleted.theme.php(all locales) — thetheme.mega.*and marketingtheme.nav.*keys (maintained locales stay at parity, 107 keys each).Tests
CoreControllerDispatchTest,CoreControllerActionsTest).PagesDiscoveryTest) and Social-cards (SocialServiceTest) tests to the one shipped view page now — the neutral home (index).Proven on tiger-dev
/renders the neutral home (nomarketing.css, no mega-menu); marketing URLs404;/docs+/login200.Companion
Pairs with the private WebTigers/TigerMarketing module (holds the lifted marketing, re-claims
/via thehome_pageconfig). Core removes marketing now that TigerMarketing holds it.🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ