You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
wcm: also take into account the icon path of wf-plugin - #125
This PR seems fine but I'm a little confused because so far, icons have been housed in wcm, not with the plugins. Can you explain how the icon setup works for wayfire-plugin or link to documentation about it?
Hi,
WCM provides icons for the "official" set of plugins, but not for third-party ones of course. I'm not sure if there is a recommended / documented way, but e.g. in my wstroke plugin, so far things worked by installing an icon to where Wayfire would put it, see here. This does not work anymore if installed with wayfire-plugin as the icon ends up under ~/.local/share/wayfire/plugin-manager/install/... (see here for the adjustments I'm currently planning to make this work at all; note that I already have some hacks to make the config GUI work, but that's a separate issue).
Thanks for explaining. I kinda wish that the paths that wayfire-plugin used matched the paths used in the wayfire install prefix, but I think that ship has sailed already. Thanks for the PR, merging..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #124 -- otherwise, icons would not be found.