Repository navigation
fix(wbn-sign): request SHA-256 explicitly for ECDSA P-256 signatures - #920
Merged
Merged
Conversation
Signing and verification passed no digest to crypto.sign()/crypto.verify() and relied on OpenSSL choosing SHA-256 for EC keys. Node.js builds based on BoringSSL have no default digest for EC keys and throw instead, so pass SHA-256 explicitly for ECDSA P-256 keys (and still no digest for Ed25519). The produced signatures are unchanged. Add a test that emulates the missing default digest for both the ESM and the CommonJS build.
zgroza
force-pushed
the
push-mmvsovltmvvt
branch
from
October 14, 2026 12:47
a29c047 to
8bdde90
Compare
rferens
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing and verification passed no digest to crypto.sign()/crypto.verify() and relied on OpenSSL choosing SHA-256 for EC keys. Node.js builds based on BoringSSL have no default digest for EC keys and throw instead, so pass SHA-256 explicitly for ECDSA P-256 keys (and still no digest for Ed25519). The produced signatures are unchanged.
Add a test that emulates the missing default digest for both the ESM and the CommonJS build.