Repository navigation
fix(wbn-sign): fix type declarations and keep ESM/CJS builds in sync - #919
Merged
Merged
Conversation
zgroza
added this pull request to stack #921
October 12, 2026 17:05
rferens
approved these changes
Oct 13, 2026
rferens
left a comment
rferens
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. That's the change that really help this package to maintain its quality and flawless releases. Great thanks!
- Point `types` in package.json at lib/wbn-sign.d.ts instead of the non-existent lib/wbn-sign.d.js. - Restore the IntegrityBlockSigner declaration: `stripInternal` dropped the whole class, because a plain comment above it mentioned the internal tag. - Keep the default `crypto` import out of the emitted declarations, which did not type-check for consumers without `esModuleInterop`. - Build and test before publishing, so that a release can no longer mix a stale ESM build with a freshly built CJS bundle (as wbn-sign@0.3.1 on npm does). - Run the tests of the public API against both the ESM and the CJS build. - Test that the package.json entry points exist, that lib/ contains no stale outputs of removed sources, and that the emitted declarations type-check.
zgroza
force-pushed
the
push-vzouqtlyzuro
branch
from
October 14, 2026 12:47
3ca98de to
e123af5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typesin package.json at lib/wbn-sign.d.ts instead of the non-existent lib/wbn-sign.d.js.stripInternaldropped the whole class, because a plain comment above it mentioned the internal tag.cryptoimport out of the emitted declarations, which did not type-check for consumers withoutesModuleInterop.