You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(core): handle invalid dates in debug serialization - #1460
Limitations: Full-repository lint, type checks and package CI were not run in this environment. Please evaluate the CI results of the final upstream PR. This change is independent of the user's other PRs.
Notes
Confirmed against the source Blob SHAs recorded in the review manifest.
AI-assisted analysis, local patch preparation, and isolated tests; the contributor is responsible for all code and scope.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
serializeValueForDebug now returns "[Date: Invalid Date]" for invalid dates. Tests check valid-date formatting, invalid-date formatting without throwing, and invalid dates inside arrays.
Changes: Date Serialization
Layer / File(s)
Summary
Invalid date formatting packages/core/src/utils/serialization/index.ts, packages/core/src/utils/serialization/invalid-date.spec.ts
serializeValueForDebug returns "[Date: Invalid Date]" for invalid dates. Tests cover valid dates, invalid dates, and invalid dates inside arrays.
The change handles invalid dates in debug serialization while preserving valid-date formatting. No remaining behavior or integration risk is identified, so the PR is ready to merge.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Description check
The description explains the change and lists validation details, but it omits the required PR checklist, explicit current behavior, explicit new behavior, linked issue or fixes reference, documentati…
Add the required PR checklist and complete the template sections for current behavior, new behavior, linked issue or fixes reference, documentation updates, changeset updates, and reviewer notes.
Passed checks: 4 passed
Check name
Status
Explanation
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title clearly and concisely describes the main change: handling invalid dates in core debug serialization.
Full details: Description check
Explanation
The description explains the change and lists validation details, but it omits the required PR checklist, explicit current behavior, explicit new behavior, linked issue or fixes reference, documentation status, and changeset status.
Resolution
Add the required PR checklist and complete the template sections for current behavior, new behavior, linked issue or fixes reference, documentation updates, changeset updates, and reviewer notes.
Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid a RangeError when serializeValueForDebug receives an invalid Date, including within arrays, while preserving valid date formatting.
Changed files
packages/core/src/utils/serialization/index.tspackages/core/src/utils/serialization/invalid-date.spec.tsValidation
Isolated exact-source TS harness: 1 pass/2 fail -> 3/3 pass; TypeScript transpile passed; git apply --check on matched fixture.
Limitations: Full-repository lint, type checks and package CI were not run in this environment. Please evaluate the CI results of the final upstream PR. This change is independent of the user's other PRs.
Notes