Skip to content

insert: Traced Mode inspector section and .vpe keyword restore - #37

Open
dcbenji wants to merge 1 commit into
VisualPinball:masterfrom
dcbenji:feat/insert-traced-mode
Open

dcbenji wants to merge 1 commit into
VisualPinball:masterfrom
dcbenji:feat/insert-traced-mode

Conversation

@dcbenji

@dcbenji dcbenji commented Oct 22, 2026

Copy link
Copy Markdown

AI-authored. Claude (Anthropic: Opus 5.5) wrote this code and the docs page at @dcbenji's request, and opened this PR on his behalf. A human has not reviewed it line by line. It was tested as described under Testing. It stays a draft until the automated review comes back clean.

Companion to freezy/VisualPinball.Engine#604 (the Insert Hybrid's opt-in Traced mode); needs it.

  • Inspector: a Traced Mode section after Baked Data. It draws the controls from the engine's InsertTracedFields (Bake, Look, Lamp Off, Bulb) and shows them only while the mode is on. Values a Look preset owns are marked the same way as the other sections.
  • .vpe packages: the resolver turns the _INSERT_TRACED toggle's value back into the keyword, because nothing at runtime syncs a toggle to its keyword. The translator ships the _Traced* maps as linear, uncompressed data, like the optical maps.

Testing: on upstream master with the engine branch, T2 compiles with no errors, the section draws, and the EditMode suite passes (1985/1985). The resolver's keyword restore wasn't exercised (URP's identical one was), and the .vpe round trip into the Player is untested (see the engine PR).

🤖 Generated with Claude Code

Draws the controls of the shader's opt-in Traced mode from the engine's
InsertTracedFields, shown only while the mode is on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The changes appear safe to merge alongside the required companion engine change.

Summary

Adds Traced Mode controls to the HDRP insert inspector and preserves traced material settings in .vpe packages.

  • HDRP inspectors now show Traced Mode controls for Insert Hybrid materials.
  • HDRP packages keep Traced Mode maps and restore its switch at runtime.

No actionable issues were found. The PR description explicitly requires the companion engine change and notes that the HDRP resolver restore and Player round trip remain untested.

Reviews (1) · Last reviewed commit: "insert: Traced Mode section in the Inser..." · Reviewed by Greptile

@dcbenji
dcbenji marked this pull request as ready for review October 22, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant