Repository navigation
Conversation
Draws the controls of the shader's opt-in Traced mode from the engine's InsertTracedFields, shown only while the mode is on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The changes appear safe to merge alongside the required companion engine change. SummaryAdds Traced Mode controls to the HDRP insert inspector and preserves traced material settings in
No actionable issues were found. The PR description explicitly requires the companion engine change and notes that the HDRP resolver restore and Player round trip remain untested. Reviews (1) · Last reviewed commit: "insert: Traced Mode section in the Inser..." · Reviewed by Greptile |
dcbenji
marked this pull request as ready for review
October 22, 2026 03:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to freezy/VisualPinball.Engine#604 (the Insert Hybrid's opt-in Traced mode); needs it.
InsertTracedFields(Bake, Look, Lamp Off, Bulb) and shows them only while the mode is on. Values a Look preset owns are marked the same way as the other sections..vpepackages: the resolver turns the_INSERT_TRACEDtoggle's value back into the keyword, because nothing at runtime syncs a toggle to its keyword. The translator ships the_Traced*maps as linear, uncompressed data, like the optical maps.Testing: on upstream master with the engine branch, T2 compiles with no errors, the section draws, and the EditMode suite passes (1985/1985). The resolver's keyword restore wasn't exercised (URP's identical one was), and the
.vperound trip into the Player is untested (see the engine PR).🤖 Generated with Claude Code