Repository navigation
HDRP runtime logging on NLog - #32
Merged
Merged
Conversation
Material resolver and auto focus log through NLog at the right levels; probes that fail on purpose log at debug, and losing subsurface scattering is a warning once per profile.
 [Medium impact] The PR appears safe to merge after its stated engine dependency. SummaryMoves HDRP runtime logs to NLog and uses warning or debug levels based on the problem.
Reviews (2) · Last reviewed commit: "logging: Warn when a diffusion profile's..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…eason. Besides an exception, HDRP renaming its internal fields or returning no hash now warns too, instead of silently losing subsurface scattering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the logging and error reporting work. It follows the level policy from freezy/VisualPinball.Engine#590: errors are for VPE bugs, and problems the user or table author can fix are warnings.
The material resolver and auto focus log through NLog instead of
Debug.Log, at the right levels. Probes that fail on purpose log at Debug. Losing subsurface scattering is a warning, once per profile.Depends on freezy/VisualPinball.Engine#590 (
LogThrottle/LogOncePerKeyand the logging-rules test that now covers this package), so merge that first.