Repository navigation
Cabinet projection support - #31
Merged
Merged
Conversation
Use the insert graphs, HLSL and presets from the main VPE package, retaining their existing asset GUIDs.
HdrpWindowProjectionAdapter hands HDRP's light loop the actual off-centre projection through nonObliqueProjectionGetter, sets a symmetric field of view and aspect enclosing it for planar probes, and resets the camera's history when the view jumps. HDRP 17.5 sizes TAA's jitter wrongly for same-sign frusta, so the cabinet view falls back to SMAA. The graphics applier mapped VPE's anti-aliasing modes onto HDRP's enum by value, but HDRP orders TAA before SMAA, so choosing one gave the other.
[Medium impact] The reviewed changes appear safe to merge; no actionable defects were established. SummaryAdds HDRP support for cabinet projection and fixes the SMAA/TAA setting mapping.
No actionable defects were established. Unity rendering was not run, and the external engine and shared asset packages were unavailable for direct checks.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDRP side of the cabinet projection (engine: freezy/VisualPinball.Engine#589).
HdrpCabinetProjectionAdapter: applies the off-centre projection throughnonObliqueProjectionGetter, resets the HD camera's history when the projection changes, and reports an enclosing field of view and aspect so culling and effects that read them stay correct. TAA falls back to SMAA while the projection is active, because TAA's history doesn't survive the custom projection.HdrpGraphicsApplier: maps the anti-aliasing setting explicitly. SMAA and TAA were swapped before because the code relied on the enum order (None, FXAA, TAA, SMAA in HDRP).a6d4958): carried on this branch; it wasn't merged with the earlier insert work.