Repository navigation
Logging levels, process output and diagnostics for the MPF engine - #50
Merged
Merged
Conversation
- Unknown switch, coil and lamp numbers are warnings, once per number. - MPF's stdout and stderr are always read when redirected (a full pipe could block MPF) and logged as "Mpf.Process", stderr by its own level. - Startup failures say which step failed and where MPF's log is, and are reported through IGamelogicStartupStatus; rethrows keep their stack trace. - The engine describes itself for error reports: MPF version, executable, machine folder, output mode, BCP state, settings.
[Medium impact] The PR appears safe to merge after its stated plugin API dependency. SummaryAdds clearer MPF logs and session diagnostics.
Both previous findings are fixed. No new issues were found in the changes since the previous review. Reviews (2) · Last reviewed commit: "logging: Keep warnings per table and ign..." · Reviewed by Greptile |
…t code. The once-per-number warnings belong to the engine instance. When MPF was started through a terminal launcher, the exit code is the launcher's, so it's no longer reported as MPF's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the logging and error reporting work. It follows the level policy from freezy/VisualPinball.Engine#590: errors are for VPE bugs, and problems the user or table author can fix are warnings. What the plugin knows goes into the session diagnostics that error reports carry.
Depends on freezy/VisualPinball.Engine#590 (the plugin API:
IPluginLog,IDiagnosticsSource,IGamelogicStartupStatus), so merge that first.