Repository navigation
Logging levels, throttles and diagnostics for the DMD plugin - #3
Merged
Merged
Conversation
Failed frames are throttled, path probes log at debug, a device that's enabled but missing is a warning, and waiting for a DMD on a table without one is normal. The plugin describes itself for error reports: source, ROM, display, destinations, colorization and its settings, with the VNI key redacted.
[Medium impact] The reviewed changes appear safe to merge after the required host API PR lands. SummaryAdds DMD logging levels, repeated-error limits, and session diagnostics for display sources, destinations, colorization, and settings.
Reviews (2) · Last reviewed commit: "logging: Throttle failures per pipeline ..." · Reviewed by Greptile |
One failing display no longer uses up another one's first errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the logging and error reporting work. It follows the level policy from freezy/VisualPinball.Engine#590: errors are for VPE bugs, and problems the user or table author can fix are warnings. What the plugin knows goes into the session diagnostics that error reports carry.
Failed frames are throttled, path probes log at debug, a device that's enabled but missing is a warning, and waiting for a DMD on a table without one is normal. The plugin describes itself for error reports: source, ROM, display, destinations, colorization and its settings, with the VNI key redacted.
Depends on freezy/VisualPinball.Engine#590 (the plugin API:
IPluginLog,IDiagnosticsSource,IGamelogicStartupStatus), so merge that first.