Repository navigation
Fall back to one representative ROI image when a tree class has no indexed domain - #131
Merged
Merged
Conversation
…dexed domain Classes in the Template ROI tree with no in_register_with index (for example the merged adult mushroom body on JRC2018Unisex) now borrow a single image registered to that template: a complete (un-sided) image if one exists, else one sided (L or R) image. Fallback entries carry fallback: true and are included in painted_domain_index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classes in the Template ROI tree with no
in_register_withindex (for example the merged adult mushroom body on JRC2018Unisex) previously came back withpainted_domain: [], so the ROI browser showed no eye for them even though an aligned image exists.These classes now borrow one image registered to the same template:
Within a tier, named-source images (e.g.
BANC:) beat unlabelled legacy ones, then the lowest short_form, so the choice is deterministic. Only images with anin_register_withedge to the template's own channel are considered, and only for classes already in the tree. Entries carryfallback: true, are included inpainted_domain_index, and the node tooltip says "Representative image ... (no painted domain)".Checked live against pdb for JRC2018Unisex (VFB_00101567): adult mushroom body resolves to VFB_00108vzl (BANC:MB); 22 further regions gain one image each. Unit tests for the picker are in
tests/test_roi_tree_fallback.py.Release note: the
template_roi_treecache holds the old shape, so refresh it after release (force refresh per template, or a version bump).