Repository navigation
scRNAseq: accept vfb-scRNAseq VFBseq_ ids alongside FlyBase FBlc ids - #127
Merged
Merged
Conversation
The scRNAseq loads are moving, study by study, from the old FlyBase/SCEA loads (FBlc ids) to the vfb-scRNAseq repo's loads (VFBseq_ ids). The queries need no change, but: - term_info fallback: VFBseq_ Samples / Assays / Clusterings stay out of the anatomical-individual index, as their FBlc predecessors did (the bulk indexer's parameter query needs the same prefix). - combine namespaces: VFBseq_ named; FBlc matched without the underscore (FBlc ids have none, so the old entry never matched). - transcriptomics tests: fixtures keep their FBlc ids while those have data, else take a live term with data (scrnaseq_fixtures.py), and cluster ids may start with FBlc or VFBseq_. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scRNAseq data is moving, study by study, from the old FlyBase/SCEA loads (
FBlc…ids) to the vfb-scRNAseq loads (VFBseq_…ids). Both id styles keep working, so this can merge before the switch.The four transcriptomics queries need no change: the new files keep the old graph shape:
Cluster/DataSetnode labels;has_source,has_referenceandcomposed_primarily_ofedges;expressesedges withexpression_level/expression_extent.That holds provided the pipeline gives the new datasets the
scRNAseq_DataSet/hasScRNAseqlabels; see Outside this repo below.Changes
term_info_fallback:VFBseq_Samples, Assays and Clusterings stay out of the anatomical-individual index, as theirFBlcpredecessors did. Datasets and Clusters are routed to their own indexers before this list is checked.combinenamespace hints:VFBseq_;FBlcis now matched without an underscore. FBlc ids have none, so the oldFBlc_entry never matched.test_transcriptomics.py,test_query_performance.py):src/test/scrnaseq_fixtures.py);FBlcorVFBseq_.Tests
tests/test_combine.pyandsrc/test/test_term_info_fallback.py: 100 passed.src/test/test_transcriptomics.py(12 tests) andtest_11_transcriptomics_queries: passed against production.Outside this repo (needed for the switch)
finalStep.py: setsscRNAseq_DataSet/hasScRNAseqonly on DataSets whose short_form starts withFBlc. VFBseq datasets need it too.VFBseq_as well, mirroring the change here.🤖 Generated with Claude Code