Repository navigation
Keep a recorder reply that arrives before a shutdown - #196
Merged
Merged
Conversation
SendAsync observes a helper reply through Task.WaitAsync, which sees the completed reply only after a queued continuation runs. When the helper finishes a save and then reports a transition or exits, a shutdown can cancel that wait first. The finished save then failed with the terminal reason instead of completing its library copy. A reply that has already arrived is now used even when the wait reports cancellation first. This was the intermittent failure of FinishedSaveCompletesItsLibraryCopyAfterTheHelperClosesForATransition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RecorderProcessClient.SendAsyncwaits for the helper's reply throughTask.WaitAsync(operation.Token). The reader sets the reply before it reports a later state or exit, but the wait observes the completed reply only after a queued continuation runs. When the helper finishes a save and then reports a transition or exits, a shutdown can cancel the wait first, and the finished save fails with the terminal reason instead of completing its library copy. This is the intermittent failure ofFinishedSaveCompletesItsLibraryCopyAfterTheHelperClosesForATransition.Change
A reply that has already arrived is used even when the wait reports cancellation first (
src/Wisp.App/Clips/RecorderProcessClient.cs, 5 lines). Nothing else changes: a cancellation with no reply still throws.Verification
Unverified: no in-game capture was run for this change; the fix is confined to the reply wait.
Closes #194