Repository navigation
Fix Firefox Dev Profile Linux, Add Path for Firefox on Fedora, Add Root User Paths for Linux, Add PlaceID to Firefox_HistoryLegacy - #54
Merged
Conversation
…ot User Paths for Linux, Add PlaceID to Firefox_HistoryLegacy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux path did not take into consideration Firefox Developer edition which uses the format qbtxwtsi.dev-edition-default rather than qbtxwtsi.default-release like the standard version.
On Fedora the path for Firefox installed from dnf package manager was observed to be /home/user/.config/mozilla/firefox/profile/ which was not accounted for.
Only normal users were covered by the globs and I validated that both Chromium and Firefox browsers can run as the root user and I have observed this behaviour on real life cases as well so makes sense to cover these like the SYSTEM user in Windows for example.
I also noticed that on #53 the PlaceID change was not made to the Firefox_HistoryLegacy.yaml file so I replicated the changes over so that everything is mirrored.
These were quick things I noticed that should improve the coverage a bit. Will be doing more deeper research over time.