feat: introduce flag validate_user_defined_fields - #352
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 91.72% 91.84% +0.12%
==========================================
Files 94 94
Lines 10038 10423 +385
==========================================
+ Hits 9207 9573 +366
- Misses 831 850 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
579d0cf to
0b8f197
Compare
|
@Vlad-Bukatin sorry, I'll get to this as soon as I can. I just have quite a lot going on, and this change is a bit larger so I want to give it a proper read. |
davidsteiner
left a comment
There was a problem hiding this comment.
The general direction looks good to me. My only functional concern is how we check the parent groups - left a comment on that.
Also, we're not too strict on test coverage, but I feel like builder.rs has a few interesting branches which aren't covered by any tests. It would be great to add some coverage for those.
Apologies for the very slow review.
|
@davidsteiner Thanks for the review! No worries at all about the delay - I've been quite busy on my end as well. Hopefully I would be able to do it next week |
|
@davidsteiner took me some time, but I think it is ready |
davidsteiner
left a comment
There was a problem hiding this comment.
@Vlad-Bukatin apart from that minor comment, this looks good to me and an improvement over the old implementation in many ways.
Once you rename the config builder, let's merge it in. If there are any edge cases remaining, we can fix those in follow ups. Thanks!
closes: #331