Fit the empty Toolkits grid to the viewport - #1897
Open
baggiiiie wants to merge 1 commit into
Open
Conversation
Each ToolkitSection shelf reserved a fixed ~3-row min-height, so the cloud grid's Workspace + Personal stack overflowed the viewport and scrolled even with zero toolkits (and padded short shelves with dead space). Size sections to content instead; the skeleton matches, and a new selfhost scenario pins the empty grid to its scroll boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
in the cloud hosted version of web UI,
Toolkitstab hasPersonalandWorkspacetwo sections, and the page is scrollable when there's noToolkitscontent, see below screen recording. changes in this PR prevent emptyToolkitspage from scrolling past its visible add cards,before
toolkits-empty-grid-before-fix.mp4
after
toolkits-empty-grid-after-fix.mp4
Linked issue
no issue open yet since it's a straightforward fix, will open one if it's preferred
Verification
bun run format:checkbun run lintbun run typecheckbun run teste2e/runs/selfhost/toolkits-empty-grid-fits-the-viewport-without-scrolling/Checklist
bun run changeset), or this change needs none.