fix(oauth): distinguish required and discovered scopes - #1879
Open
aryasaatvik wants to merge 1 commit into
Open
Conversation
Persist required scopes separately from dynamically advertised capabilities so partial grants only warn when explicit integration or client policy is unsatisfied.
aryasaatvik
marked this pull request as ready for review
August 30, 2026 09:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Distinguish scopes required by integration or client policy from capabilities discovered through OAuth metadata. This prevents a valid partial grant from being reported as missing every supported capability the authorization server advertised.
scopes_supportedThis follows RFC 9728 section 7.2:
scopes_supporteddescribes supported values, not a directive that every value must be granted. Legacy in-flight OAuth sessions retain their previous requested-scope fallback.Validation
bunx vitest run src/oauth-scope-union.test.ts src/oauth-flow.test.tsbun run typecheckbunx oxlint -c ../../../.oxlintrc.jsonc src/oauth-service.ts src/oauth-scope-union.test.ts --deny-warningsbunx vitest run(861 passed)